Skip to content

fix(docs): clean up npm uninstall docs #2464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

fix(docs): clean up npm uninstall docs #2464

wants to merge 8 commits into from

Conversation

wraithgar
Copy link
Member

Lots of flags removed, clarification on what --no-save does,
consolidated examples into a separate section

References

Closes npm/statusboard#252

@wraithgar wraithgar requested a review from a team as a code owner January 8, 2021 23:16
@wraithgar
fix(docs): clean up npm uninstall docs
64f0ae5 
Lots of flags removed, clarification on what `--no-save` does,
consolidated examples into a separate section
@wraithgar wraithgar added the release: next These items should be addressed in the next release label Jan 8, 2021
@npm-deploy-user
Copy link

npm-deploy-user commented Jan 8, 2021 •
edited
Loading

found 2 benchmarks with statistically significant performance improvements

  • app-large: no-clean:audit
  • app-medium: cache-only
timing results
app-large clean lock-only cache-only cache-only
legacy-peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 46.568 ±2.13 27.724 ±0.02 32.024 ±4.26 31.159 ±1.49 2.193 ±0.03 2.254 ±0.06 1.539 ±0.01 11.879 ±0.17 1.540 ±0.06 4.489 ±0.20
#2464 46.682 ±0.19 27.749 ±0.33 30.096 ±0.01 28.670 ±1.36 2.219 ±0.01 2.171 ±0.04 1.580 ±0.07 11.991 ±0.20 1.559 ±0.05 3.584 ±0.28
app-medium clean lock-only cache-only cache-only
legacy-peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@7 33.636 ±1.77 19.497 ±0.16 24.362 ±2.31 19.406 ±1.74 2.103 ±0.02 2.116 ±0.03 1.437 ±0.01 7.490 ±0.07 1.441 ±0.05 2.731 ±0.15
#2464 34.190 ±0.31 19.608 ±0.38 21.113 ±0.36 20.658 ±0.15 2.106 ±0.02 2.139 ±0.07 1.464 ±0.04 7.501 ±0.15 1.461 ±0.04 2.779 ±0.19

@darcyclarke darcyclarke added the Release 7.x work is associated with a specific npm 7 release label Jan 9, 2021
ljharb
ljharb reviewed Jan 12, 2021
View reviewed changes
ljharb
ljharb reviewed Jan 12, 2021
View reviewed changes
@wraithgar wraithgar requested a review from ljharb January 12, 2021 20:59
ljharb
ljharb approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

darcyclarke
darcyclarke suggested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to delineate a package's name (suggested code but maybe bold)

wraithgar and others added 2 commits January 14, 2021 12:39
@wraithgar wraithgar mentioned this pull request Jan 14, 2021
Merged
@wraithgar wraithgar closed this in a3c1274 Jan 14, 2021
@ruyadorno ruyadorno mentioned this pull request Jan 15, 2021
Closed
@wraithgar wraithgar deleted the gar/docs_uninstall branch November 2, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@ljharb ljharb ljharb approved these changes

@nlf nlf nlf approved these changes

@darcyclarke darcyclarke darcyclarke approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7(docs): uninstall
5 participants
@wraithgar @npm-deploy-user @ljharb @nlf @darcyclarke